fixed: #5205 correct typings for effect functions by danielrentz ยท Pull Request #5335 ยท codeceptjs/CodeceptJS

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@danielrentz

Copy link Copy Markdown

Contributor

Motivation/Description of the PR

Fixes for type definitions of the effect functions tryTo, hopeThat, and retryTo.

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • ๐Ÿ”ฅ Breaking changes
  • ๐Ÿš€ New functionality
  • ๐Ÿ› Bug fix
  • ๐Ÿงน Chore
  • ๐Ÿ“‹ Documentation changes/updates
  • โ™จ๏ธ Hot fix
  • ๐Ÿ”จ Markdown files fix - not related to source code
  • ๐Ÿ’… Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)
Copy link Copy Markdown

Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@DavertMik

Copy link Copy Markdown

Contributor

@DenysKuchma can we make this into 4.x branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve TypeScript types for effect functions (hopeThat, tryTo, retryTo)

3 participants

@danielrentz @DavertMik