Fixes #163: Regression: encoding error when parsing a ISO-8859-1 xml by belingueres · Pull Request #164 · codehaus-plexus/plexus-utils
Navigation Menu
{{ message }}
codehaus-plexus / plexus-utils Public
- Notifications You must be signed in to change notification settings
- Fork 44
Merged
olamy merged 1 commit intocodehaus-plexus:masterfrom
Aug 26, 2021Merged
Fixes #163: Regression: encoding error when parsing a ISO-8859-1 xml#164
olamy merged 1 commit intocodehaus-plexus:masterfrom
Fixes #163: Regression: encoding error when parsing a ISO-8859-1 xml#164
olamy merged 1 commit intocodehaus-plexus:masterfrom
Conversation
…ISO-8859-1 xml - Fixed code. - Added tests.
olamy approved these changes Aug 9, 2021
| MXParser parser = new MXParser(); | ||
| parser.setInput( reader ); | ||
| while ( parser.nextToken() != XmlPullParser.END_DOCUMENT ) | ||
| ; |
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit I would prefer nothing rather than this (maybe only me but looks weird this :) )
| MXParser parser = new MXParser(); | ||
| parser.setInput( input, null ); | ||
| while ( parser.nextToken() != XmlPullParser.END_DOCUMENT ) | ||
| ; |
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit I would prefer nothing rather than this (maybe only me but looks weird this :) )
olamy
merged commit
bb346ad
into
codehaus-plexus:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment