Provides a CachingOuptutStream and a CachingWriter by gnodet · Pull Request #184 · codehaus-plexus/plexus-utils
Navigation Menu
{{ message }}
codehaus-plexus / plexus-utils Public
- Notifications You must be signed in to change notification settings
- Fork 44
Merged
cstamas merged 8 commits intocodehaus-plexus:masterfrom
Apr 26, 2022Merged
Provides a CachingOuptutStream and a CachingWriter#184
cstamas merged 8 commits intocodehaus-plexus:masterfrom
Provides a CachingOuptutStream and a CachingWriter#184
cstamas merged 8 commits intocodehaus-plexus:masterfrom
Conversation
Copy link
Member
gnodet
commented
Feb 21, 2022
gnodet
commented
This could be used instead of codehaus-plexus/modello#116 , codehaus-plexus/plexus-containers#46 and apache/maven-plugin-tools#67
olamy
added
the
enhancement
label
olamy approved these changes Feb 22, 2022
olamy reviewed Feb 22, 2022
src/main/java/org/codehaus/plexus/util/io/CachingOutputStream.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/util/io/CachingOutputStream.java Outdated Show resolved Hide resolved
olamy reviewed Feb 22, 2022
src/main/java/org/codehaus/plexus/util/io/CachingWriter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/util/io/CachingWriter.java Outdated Show resolved Hide resolved
gnodet added 3 commits
February 22, 2022 09:36sonatype-lift bot reviewed Feb 22, 2022
src/main/java/org/codehaus/plexus/util/io/CachingOutputStream.java
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/util/io/CachingOutputStream.java Show resolved Hide resolved
gnodet added 2 commits
February 22, 2022 09:49
gnodet
requested a review
from olamy
gnodet
mentioned this pull request
gnodet
force-pushed
the
caching-writer
branch
from
9d69ee8 to
4473d24
Compare
sonatype-lift bot reviewed Apr 25, 2022
src/main/java/org/codehaus/plexus/util/io/CachingOutputStream.java
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/util/io/CachingOutputStream.java Show resolved Hide resolved
cstamas approved these changes Apr 25, 2022
Copy link
Member Author
gnodet
commented
Apr 26, 2022
gnodet commented
Apr 26, 2022@olamy @michael-o @cstamas could one of you squash/merge this PR ? I don't have any karma to do it.
Copy link
Member
michael-o
commented
Apr 26, 2022
michael-o commented
Apr 26, 2022@olamy @michael-o @cstamas could one of you squash/merge this PR ? I don't have any karma to do it.
Interactive rebase does not work for you in the terminal?
Copy link
Member Author
gnodet
commented
Apr 26, 2022
gnodet commented
Apr 26, 2022@olamy @michael-o @cstamas could one of you squash/merge this PR ? I don't have any karma to do it.
Interactive rebase does not work for you in the terminal?
I suppose it does, however, I can't push to the codehaus-plexus repositories as I'm not a member of this org. So it's more about the merge part than the squash ;-)
cstamas
merged commit
49773f1
into
codehaus-plexus:master
Copy link
Member
cstamas
commented
Apr 26, 2022
cstamas commented
Apr 26, 2022@gnodet seems merged code UT failed?
Copy link
Member Author
gnodet
commented
Apr 26, 2022
gnodet commented
Apr 26, 2022Weird, that's the one I fixed with 0c03b46
Copy link
Member Author
gnodet
commented
Apr 26, 2022
gnodet commented
Apr 26, 2022So the test is flaky under linux. I'll provide a PR to make it more robust or fix the problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment