Don't overwrite blank (but non-empty) dominant values during mergeXpp3Dom by kwin · Pull Request #213 · codehaus-plexus/plexus-utils
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 44
Conversation
kwin
mentioned this pull request
kwin
changed the title
Add test exposing that dominant blank (but non-empty) values are
Don't overwrite blank (but non-empty) dominant values during mergeXpp3Dom
kwin
marked this pull request as ready for review
I wonder what will fail with current downstream consumer tests
Any particular tests you have in mind? I will try to run Maven ITs against this change.
I wonder what will fail with current downstream consumer tests
Any particular tests you have in mind? I will try to run Maven ITs against this change.
Run this patched version against Core plugins ITs.
I modified Maven master to define
<plexusUtilsVersion>3.4.3-SNAPSHOT</plexusUtilsVersion> in the reactor pom.xml, build it and ran the Maven Core integration tests successfully against that distro.
I modified Maven master to define
<plexusUtilsVersion>3.4.3-SNAPSHOT</plexusUtilsVersion>in the reactor pom.xml, build it and ran the Maven Core integration tests successfully against that distro.
Good, I will repeat with several core plugin ITs with 3.9.0-SNAPSHOT tomorrow.
Will this PR completely cover the downstream Maven issue?
Will this PR completely cover the downstream Maven issue?
No, it just allows to apply a workaround by giving a blank value in the plugin configuration to disable the default handling (FTR: the downstream issue is https://issues.apache.org/jira/browse/MNG-6434).
kwin
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters