Don't overwrite blank (but non-empty) dominant values during mergeXpp3Dom by kwin · Pull Request #213 · codehaus-plexus/plexus-utils

Skip to content

Navigation Menu

Sign in

Appearance settings

Conversation

@kwin kwin mentioned this pull request

Sep 11, 2022

@kwin kwin changed the title Add test exposing that dominant blank (but non-empty) values are Don't overwrite blank (but non-empty) dominant values during mergeXpp3Dom

Sep 11, 2022

@kwin kwin marked this pull request as ready for review

September 11, 2022 10:55

michael-o

@michael-o

I wonder what will fail with current downstream consumer tests

@kwin

I wonder what will fail with current downstream consumer tests

Any particular tests you have in mind? I will try to run Maven ITs against this change.

@michael-o

I wonder what will fail with current downstream consumer tests

Any particular tests you have in mind? I will try to run Maven ITs against this change.

Run this patched version against Core plugins ITs.

@michael-o

I'd like to run tests on plugins. Does it suffice to update Maven Core with this patch?

@kwin

I modified Maven master to define
<plexusUtilsVersion>3.4.3-SNAPSHOT</plexusUtilsVersion> in the reactor pom.xml, build it and ran the Maven Core integration tests successfully against that distro.

@michael-o

I modified Maven master to define <plexusUtilsVersion>3.4.3-SNAPSHOT</plexusUtilsVersion> in the reactor pom.xml, build it and ran the Maven Core integration tests successfully against that distro.

Good, I will repeat with several core plugin ITs with 3.9.0-SNAPSHOT tomorrow.

Will this PR completely cover the downstream Maven issue?

@kwin

Will this PR completely cover the downstream Maven issue?

No, it just allows to apply a workaround by giving a blank value in the plugin configuration to disable the default handling (FTR: the downstream issue is https://issues.apache.org/jira/browse/MNG-6434).

@sonatype-lift

@kwin kwin mentioned this pull request

Oct 10, 2022

2 participants

@kwin @michael-o