chore!: send modules archive over the proto messages by Emyrk · Pull Request #21398 · coder/coder
Emyrk
mentioned this pull request
Emyrk
changed the base branch from
stevenmasley/remove_exp
to
graphite-base/21398
Emyrk
changed the base branch from
graphite-base/21398
to
01-07-chore_update_protobuf_to_reuse_file_request
Emyrk
mentioned this pull request
Emyrk
marked this pull request as ready for review
Emyrk
added
the
release/breaking
label
Jan 9, 2026
Emyrk
changed the title
chore: send modules archive over the proto messages
chore!: send modules archive over the proto messages
Emyrk added a commit that referenced this pull request
Jan 9, 2026Experiment is no longer required, the new method will be released without an experiment and without a toggle Main PR is: #21398
Emyrk
changed the base branch from
01-07-chore_update_protobuf_to_reuse_file_request
to
graphite-base/21398
Emyrk added a commit that referenced this pull request
Jan 9, 2026**This is just the protobuf changes for the PR #21398 Moved `UploadFileRequest` from `provisionerd.proto` -> `provisioner.proto`. Renamed to `FileUpload` because it is now bi-directional. This **is backwards compatible**. I tested it to confirm the payloads are identical. Types were just renamed and moved around. ```golang func TestTypeUpgrade(t *testing.T) { t.Parallel() x := &proto2.UploadFileRequest{ Type: &proto2.UploadFileRequest_ChunkPiece{ ChunkPiece: &proto.ChunkPiece{ Data: []byte("Hello World!"), FullDataHash: []byte("Foobar"), PieceIndex: 42, }, }, } data, err := protobuf.Marshal(x) require.NoError(t, err) // Exactly the same output // EhgKDEhlbGxvIFdvcmxkIRIGRm9vYmFyGCo= on `main` // EhgKDEhlbGxvIFdvcmxkIRIGRm9vYmFyGCo= on this branch fmt.Println(base64.StdEncoding.EncodeToString(data)) } ``` # What this does This allows provisioner daemons to download files from `coderd`'s `files` table. This is used to send over cached module files and prevent the need of downloading these modules on each workspace build.
Emyrk
changed the base branch from
graphite-base/21398
to
main
Emyrk
deleted the
stevenmasley/modules_over_the_wire
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters