chore: move Shared Workspaces from experiments to beta by zenithwolf1000 · Pull Request #22206 · coder/coder
zenithwolf1000
changed the title
Moving Shared Workspaces out of experiments -> beta
chore: move Shared Workspaces out of experiments -> beta
zenithwolf1000
changed the title
chore: move Shared Workspaces out of experiments -> beta
chore: move Shared Workspaces from experiments to beta
Remove empty DeploymentValues callbacks from workspace ACL tests in coderd/workspaces_test.go. These were left over from the workspace-sharing experiment removal and should be replaced with nil for cleaner test setup. Changes: - TestDeleteWorkspaceACL/WorkspaceOwnerCanDelete - TestDeleteWorkspaceACL/SharedUsersCannot - TestWorkspaceReadCanListACL
Per PR review feedback, remove empty DeploymentValues callbacks and the Options structs that only contained them. When Options becomes empty, pass nil instead for cleaner test setup. Changes: - cli/sharing_test.go: Simplified 6 test cases - enterprise/cli/sharing_test.go: Removed empty Options from 6 test cases This completes the cleanup from removing the workspace-sharing experiment flag.
Remove outdated experiment messaging from the --disable-workspace-sharing flag description. The workspace sharing feature is now in beta and no longer requires an experiment flag to be enabled. Changed: - Removed "(requires the 'workspace-sharing' experiment to be enabled)" from the flag description
Address remaining review comments from PR #22206: 1. cli/list_test.go: Simplify empty Options to nil - Remove empty DeploymentValues callback wrapper 2. OrganizationSettingsPageView.tsx: Change span to div for title - Replace inline span with div for block-level flex container - Using span as a block element is frowned upon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters