Properly handle CaseInsensitiveEnumValues flag. by niklaskarl · Pull Request #231 · commandlineparser/commandline
Navigation Menu
{{ message }}
commandlineparser / commandline Public
- Notifications You must be signed in to change notification settings
- Fork 480
Merged
ericnewton76 merged 1 commit intocommandlineparser:masterfrom
Aug 13, 2018Merged
Properly handle CaseInsensitiveEnumValues flag.#231
ericnewton76 merged 1 commit intocommandlineparser:masterfrom
Properly handle CaseInsensitiveEnumValues flag.#231
ericnewton76 merged 1 commit intocommandlineparser:masterfrom
Conversation
Copy link Copy Markdown
niklaskarl
commented
Jan 25, 2018
niklaskarl
commented
This fixes #198.
It simply passes the value of the CaseInsensitiveEnumValues setting down to the InstanceChooser.Choose method. Previously the method used a constant value of false.
mleenhardt
mentioned this pull request
Copy link Copy Markdown
Member
ericnewton76
commented
Mar 27, 2018
ericnewton76 commented
Mar 27, 2018Can you add some tests for both false and true conditions, just for peace of mind :)
ericnewton76
added this to the
2.3.0 milestone
Copy link Copy Markdown
masters3d
commented
Jun 7, 2018
masters3d commented
Jun 7, 2018@niklaskarl What is the default now?
Copy link Copy Markdown
masters3d
commented
Jun 7, 2018
masters3d commented
Jun 7, 2018@niklaskarl Do you need help adding the additional tests?
ericnewton76
merged commit
ec0e51d
into
commandlineparser:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants