Tests cleanup by gsscoder · Pull Request #560 · commandlineparser/commandline

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@gsscoder

Copy link Copy Markdown

Contributor

@gsscoder gsscoder commented

Jan 8, 2020

Just some few order in test code.

using FluentAssertions;
using Microsoft.FSharp.Core;
using CommandLine.Tests.Fakes;

Copy link Copy Markdown

Collaborator

@moh-hassan moh-hassan

Jan 8, 2020

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

//Microsoft.FSharp.Core is needed for fsharp Target_Build. This is the reason for appveyor fail

Suggested change

#if !SKIP_FSHARP
using Microsoft.FSharp.Core;
#endif

@moh-hassan moh-hassan changed the base branch from master to develop

January 8, 2020 20:06

@moh-hassan moh-hassan merged commit f1a6527 into commandlineparser:develop

Jan 8, 2020

@gsscoder gsscoder deleted the tests-cleanup branch

January 9, 2020 05:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moh-hassan moh-hassan moh-hassan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gsscoder @moh-hassan