fix: fix the "isFunction" utility to match both "AsyncFunction" by tal-rofe · Pull Request #927 · commitizen/cz-cli

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

LinusU merged 1 commit intocommitizen:masterfrom

tal-rofe:master

Apr 25, 2022

Conversation

@tal-rofe

Copy link

Contributor

fix: fix the "isFunction" utility to match both "AsyncFunction"

current behavior is the utility tries to match only "Function" and therefore "AsyncFunction" will be
considered bad and error will be thrown

fix #926

…"Function"s

current behavior is the utility tries to match only "Function" and therefore "AsyncFunction" will be
considered bad and error will be thrown

fix #926

@LinusU LinusU merged commit 25dc80c into commitizen:master

Apr 25, 2022

@LinusU

Copy link

Contributor

LinusU commented

Apr 25, 2022

Thanks 👍

@github-actions

Copy link

🎉 This PR is included in version 4.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Could not find prompter method in the provided adapter module: dist/index.js"

2 participants

@tal-rofe @LinusU