UPDATE build to work on RHEL-8 by robnester-rh · Pull Request #703 · conforma/cli

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@robnester-rh

Copy link

Contributor

This commit addresses HACBS-2210 by setting CGO_ENABLED=0 to avoid linking to libc.

This commit addresses HACBS-2210 by setting `CGO_ENABLED=0` to avoid
linking to `libc`.

Signed-off-by: Rob Nester <rnester@redhat.com>

@codecov

Copy link

codecov bot commented

May 18, 2023

edited

Loading

Codecov Report

Merging #703 (50669bb) into main (eb026b1) will increase coverage by 7.88%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #703      +/-   ##
==========================================
+ Coverage   77.77%   85.65%   +7.88%     
==========================================
  Files          46       52       +6     
  Lines        4148     4379     +231     
==========================================
+ Hits         3226     3751     +525     
+ Misses        922      628     -294     
Flag Coverage Δ
acceptance 67.35% <ø> (?)
generative 49.32% <ø> (ø)
integration 60.11% <ø> (ø)
unit 68.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 29 files with indirect coverage changes

@robnester-rh robnester-rh merged commit ff828bb into conforma:main

May 19, 2023

@robnester-rh robnester-rh deleted the HACBS-2210 branch

September 13, 2023 15:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zregvart zregvart zregvart approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robnester-rh @zregvart