Add configure_additional_bank Functionality and Bump Version to 1.2.17 by gmorales96 · Pull Request #169

Add configure_additional_bank Functionality and Bump Version to 1.2.17 by gmorales96 · Pull Request #169 · cuenca-mx/clabe-python

added 22 commits

December 10, 2024 17:24

…-mx/clabe-python into feature/add-editable-banks-config

…th Pydantic model validation

…k codes

- Replaced bank_code_abm with a derived property from bank_code_banxico.
- Enhanced validation for bank_code_banxico to ensure it is exactly 5 digits.
- Updated tests to reflect changes in bank configuration logic and validation rules.

…idation logic

- Refactored the add_bank function to improve clarity and validation.
- Updated tests to align with the new function name and validation rules.

…ditional_bank to add_bank

pachCode deleted the feature/add-editable-banks-config branch

December 26, 2024 17:06

gmorales96 added a commit that referenced this pull request

Dec 27, 2024

#169)

* ci: add Codecov token to workflow configuration

* feat: add error handling for existing bank codes and names

* ci: update GitHub Actions workflow to use new action versions

* chore: bump version to 1.2.17.dev1

* chore: update GitHub Actions workflows for release and testing

* fix: update PyPI token reference in GitHub Actions workflow

* fix: update PyPI token reference in release workflow to use PYPI_API_TOKEN

* refactor: rename and update error classes for bank code validation

* feat: add configure_additional_bank function and corresponding tests

* docs: update README to include instructions for add a new bank

* chore: bump version to 1.2.17.dev2

* chore: bump version to 1.2.17

* chore: update GitHub Actions workflows for release and testing

* fix: update PyPI token reference in GitHub Actions workflow

* fix: update PyPI token reference in release workflow to use PYPI_API_TOKEN

* refactor: rename and update error classes for bank code validation

* feat: add configure_additional_bank function and corresponding tests

* docs: update README to include instructions for add a new bank

* chore: bump version to 1.2.17.dev2

* chore: bump version to 1.2.17

* feat: enhance configure_additional_bank with input validation

* refactor: streamline bank configuration by replacing error classes with Pydantic model validation

* refactor: update BankConfigRequest model and validation logic for bank codes

- Replaced bank_code_abm with a derived property from bank_code_banxico.
- Enhanced validation for bank_code_banxico to ensure it is exactly 5 digits.
- Updated tests to reflect changes in bank configuration logic and validation rules.

* feat: add remove_bank function to manage bank entries

* docs: update README to include instructions for adding a new bank

* refactor: rename configure_additional_bank to add_bank and update validation logic

- Refactored the add_bank function to improve clarity and validation.
- Updated tests to align with the new function name and validation rules.

* docs: update README to reflect function name change from configure_additional_bank to add_bank

---------

Co-authored-by: gabino <gabino@cuenca.com>