Double check these details before you open a PR

• PR does not match another non-stale PR currently opened
• PR name matches the format new icon: Icon name (versions separated by comma). More details here
• PR's base is the develop branch.
• Your icons are inside a folder as seen here
• SVG matches the standards laid out here
• A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

• Firebase Website
• Firebase Branding

Additional Notes

The yellow color #ffcc2e was used for the font SVGs and is can be found on the bottom shape of the original svg.

weh approved these changes Dec 5, 2023

weh left a comment

LGTM 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great PR! However I'm not sure that yellow is the right color choice. I feel like the middle orange color (#ffa712) should be chosen instead.
Anecdotally I've found that orange is more commonly used on their website, it's also what I associate with firebase. Another good reason to pick that color imo is that it's a middle-point between the yellow (#ffcc2e) and dark orange (#f6830e) color, and it's more easily visible on white backgrounds, while also being bright enough for dark backgrounds.

Would love a 2nd and 3rd opinion on this though, which is why this is a "comment" and not a "request changes" review. @lunatic-fox @canaleal @weh what do you guys think?

Honestly, I was little hesitant on choosing yellow for those exact same reasons (Hard to see, prominent on the logo but not the most common color on the website). I think the dark orange is a bit too much, but the middle orange #ffc928 is just right.

I didn't take a close look at the website, but from just a quick look, it looked like there were multiple different shades of yellow/orange being used.

Sidenote: Another reason is that the dark orange seems to be the "shadow color", and the yellow seems to be the "highlight color". By that logic the light orange color would be the "base color".

Another great PR! However I'm not sure that yellow is the right color choice. I feel like the middle orange color (#ffa712) should be chosen instead. Anecdotally I've found that orange is more commonly used on their website, it's also what I associate with firebase. Another good reason to pick that color imo is that it's a middle-point between the yellow (#ffcc2e) and dark orange (#f6830e) color, and it's more easily visible on white backgrounds, while also being bright enough for dark backgrounds.

Would love a 2nd and 3rd opinion on this though, which is why this is a "comment" and not a "request changes" review. @lunatic-fox @canaleal @weh what do you guys think?

I like the Firebase Amber which is #ffa000.

Here are the official colors:
Firebase Yellow: #ffca28
Firebase Amber: #ffa000
Firebase Orange: #f57c00

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…vicon into update-icon-firebase

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.