new icon: vaadin (original, original-wordmark) by weh ยท Pull Request #2188 ยท devicons/devicon
Double check these details before you open a PR
- PR does not match another non-stale PR currently opened
- PR name matches the format new icon: Icon name (versions separated by comma). More details here
- PR's base is the
developbranch. - Your icons are inside a folder as seen here
- SVG matches the standards laid out here
- A new object is added in the
devicon.jsonfile at the correct alphabetic position as seen here
i think a plain-wordmark or line* version would not be allowed
https://vaadin.com/trademark
This PR closes NONE
closes #1003
Link to prove your SVG is correct and up-to-date.
Hi!
I'm the check-bot and we have some issues with your PR:
devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60
Error found regarding filenames:
- This path doesn't exist: '/home/runner/work/devicon/devicon/icons/vaadin/vaadin-original-wordmark.svg'
Error checking SVGs: no SVGs to check. Might be caused by above issues.
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help,
SVG-Checker Bot ๐
Hi!
I'm the check-bot and we have some issues with your PR:
devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help,
SVG-Checker Bot ๐
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ๐
Also yeah, it seems like only the white version is accepted as an alternative color to the SVGs. Making a line version will also go against their policy.
Hi!
I'm the check-bot and we have some issues with your PR:
devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help,
SVG-Checker Bot ๐
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request
Dec 20, 2024This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

