new icon: gitkraken (original, original-wordmark, plain, plain-wordmark) by boterop ยท Pull Request #2280 ยท devicons/devicon
Double check these details before you open a PR
- PR does not match another non-stale PR currently opened
- PR name matches the format new icon: Icon name (versions separated by comma). More details here
- PR's base is the
developbranch. - Your icons are inside a folder as seen here
- SVG matches the standards laid out here
- A new object is added in the
devicon.jsonfile at the correct alphabetic position as seen here
This PR closes #1455
Link to prove your SVG is correct and up-to-date.
Hi!
I'm the check-bot and we have some issues with your PR:
devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help,
SVG-Checker Bot ๐
1 similar comment
Hi!
I'm the check-bot and we have some issues with your PR:
devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help,
SVG-Checker Bot ๐
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! ๐ฏ
I optimized the SVGs using SVGOMG and checked them with IcoMoon for any artifacts.
Additionally, since the original SVG contains only one path and fill color, it can also serve as an alias for the plain SVG.
weh requested changes Oct 15, 2024
weh
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes, the rest looks good ๐
weh requested changes Jan 6, 2025
weh
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SVG needs to be on a single line, with a following empty line.
That is all ๐
weh previously approved these changes Jan 15, 2025
weh
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now ๐
Hi!
I'm the check-bot and we have some issues with your PR:
devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60
Check our CONTRIBUTING guide for more details regarding these errors.
Please address these issues. When you update this PR, I will check your SVGs again.
Thanks for your help,
SVG-Checker Bot ๐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters