Updated the svg checker so it doesn't post confirmation messages and updated CONTRIBUTING.md by Thomas-Boi · Pull Request #542 · devicons/devicon

@Thomas-Boi

This PR is to resolve issues #534 and another PR where there were issues with our naming convention.

From now on, all names will be lowercase and concatenated. If the original name has a hyphen, I supposed it can be kept. The build script should have no issue with hyphens in name for building CSS or icon files. As long as it matches the svg files, it works.

@Thomas-Boi

@Thomas-Boi

@amacado

amacado

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a deep test this looks good to me! :) I just have the feeling that cutenode/action-always-fail@v1.0.1 could be replaced without a vendor action. If I get it right, this action will just fail? This could probably done without any vendor component, or?

Anyway: Thanks for improving and you have my approval! @Panquesito7 might wanna take a look before merging?

@Thomas-Boi

Without a deep test this looks good to me! :) I just have the feeling that cutenode/action-always-fail@v1.0.1 could be replaced without a vendor action. If I get it right, this action will just fail? This could probably done without any vendor component, or?

That's true. I originally wanted to have a clean way to fail the workflow and this action seems to be it. If this fails because of the action, we would have a message that says "This action intentionally fails etc..." rather than if we run a bogus command like "fake-command". If we run into any weird issues I'll fail the script manually 👍

Panquesito7

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution! 👍 🎉

@Panquesito7 Panquesito7 deleted the thomas/feature/workflowAndContributing branch

March 30, 2021 16:33

@Thomas-Boi Thomas-Boi linked an issue

Apr 2, 2021

that may be closed by this pull request

GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request

Dec 20, 2024
…AndContributing

Updated the svg checker so it doesn't post confirmation messages and updated CONTRIBUTING.md