Reuse configs for `GroovyExtension` and `GroovyGradleExtension` by Goooler · Pull Request #1892 · diffplug/spotless
Comment on lines -38 to +29
| public class GroovyExtension extends FormatExtension implements HasBuiltinDelimiterForLicense, JvmLang { | ||
| public class GroovyExtension extends BaseGroovyExtension implements HasBuiltinDelimiterForLicense, JvmLang { |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we implement HasBuiltinDelimiterForLicense for GroovyGradleExtension? If so we can move this into BaseGroovyExtension as well.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's pretty hard to find the regex for Groovy, I think it's really hard to find it for GroovyGradle, as anything could be at the top. IMO hiding this regex from the user is counterproductive because too likely that they will end up needing to change something about it.
Goooler
changed the title
Reuse configs for GroovyExtension and GroovyGradleExtension
Reuse configs for GroovyExtension and GroovyGradleExtension
Goooler
deleted the
reuse-groovy-configs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters