Home Original page

Feature/use native npm by simschla · Pull Request #606 · diffplug/spotless

and others added 24 commits

June 7, 2020 21:27
namely start a node-server and rest-call into that node-server
due to missing package.json files
and improve http resource handling
- I'm a big fan of prettier, and use it a lot myself
- But I don't want npm to be a must-have for Spotless devs
- That is why we have a separate CircleCI job `test_npm_8`, which is the only one that requires npm
somehow the mavenRunner got stuck when there was no stdout/stderr output. Fixing implementation as to detect when that is the case and to simplify things actually read stdout/stderr within the actual main thread, not seperately spawned threads.
the problem appears to be that on unix, the node-serve call is spawning sub-processes. Subprocesses, however, are obviously not correctly terminated by the java ProcessBuilder-API.

The current solution is to actively call the rest service and request a shutdown of the process from within the api and only fall back to ProcessBuilder api if that does not work.

@nedtwigg

nedtwigg

nedtwigg

@simschla

@simschla

@simschla

@simschla

@simschla

@simschla simschla deleted the feature/use-native-npm branch

January 10, 2023 07:39