spotlessApply no longer clobbers file permissions by tglaeser · Pull Request #656 · diffplug/spotless

@tglaeser

… to remember the file attributes

@tglaeser

nedtwigg

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks! To get this merged, we need two things:

  • a unit test, here is a good example. I would take your word that the code works, but without a unit test I am sure that we will break it again in the future.
  • an entry in this changelog

@tglaeser

…a.nio.file.attribute' are not fs agnostic; as we prefer not having fs specific conditions, we limit ourselvs to basic attribute

@tglaeser

…age 'java.nio.file.attribute' are not fs agnostic; as we prefer not having fs specific conditions, we limit ourselvs to basic attribute"

This reverts commit 63d8579.

@nedtwigg

@nedtwigg nedtwigg changed the title Fix for issue 654 ... copy the original file to the tmp location just… Fix for issue #654 ... copy the original file to the tmp location just…

Aug 5, 2020

@nedtwigg nedtwigg changed the title Fix for issue #654 ... copy the original file to the tmp location just… spotlessApply no longer clobbers file permissions

Aug 5, 2020

@nedtwigg

@nedtwigg

@nedtwigg

I changed the test more explicitly reproduce the original problem you found. Thanks for the find and the fix, this will get released within 48 hrs.

@nedtwigg

Released in plugin-gradle 5.1.1