Home Original page

check buildx version before comparing it by yangfeiyu20102011 · Pull Request #13415 · docker/compose

@yangfeiyu20102011

What I did

Related issue

#13414
(not mandatory) A picture of a cute animal, if possible in relation to what you did

ndeloof

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
any idea about circumstances for buildx plugin to be available but no version can be extracted?

ndeloof

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look at the docker/cli pluginManager code:
Actually, getPlugin may return a plugin instance and err=nil, but plugin.Err gives more details on some missing plugin expectation (typically: failure to get plugin metadata). This Err should be checked as well

@yangfeiyu20102011 

Signed-off-by: yangfeiyu <yangfeiyu20102011@163.com>

@yangfeiyu20102011

I had a look at the docker/cli pluginManager code: Actually, getPlugin may return a plugin instance and err=nil, but plugin.Err gives more details on some missing plugin expectation (typically: failure to get plugin metadata). This Err should be checked as well
OK. How about get and check it in getBuildxPlugin. @ndeloof

ndeloof

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request

Dec 19, 2025