Home Original page

docker 1.8+ no longer needs dind by jessfraz · Pull Request #15596 · moby/moby

@jessfraz

ping @tianon idk what to make the entrypoint tbh or if you think this is too soon ;)

@jessfraz

hmm weird errors... need to investigate why...

@jessfraz

the windows side is because i need to update those servers

@thaJeztah

@dmp42 dmp42 mentioned this pull request

Aug 19, 2015

@tianon

Ohh, because it auto-mounts the cgroup hierarchy? Very interesting indeed.

IMO we should still keep the entrypoint around for a while since it'll still be needed on older Docker versions, but making it do the mounting nonsense conditionally based on whether we've already got it all mounted seems really sane. 👍 (ie, if ! mountpoint -q /sys/fs/cgroup; then ...)

@jessfraz

nice yeah

On Fri, Aug 21, 2015 at 10:23 AM, Tianon Gravi notifications@github.com
wrote:

Ohh, because it auto-mounts the cgroup hierarchy? Very interesting indeed.

IMO we should still keep the entrypoint around for a while since it'll
still be needed on older Docker versions, but making it do the mounting
nonsense conditionally based on whether we've already got it all mounted
seems really sane. [image: 👍](ie, if ! mountpoint -q /sys/fs/cgroup;
then ...)

—
Reply to this email directly or view it on GitHub
#15596 (comment).

@jessfraz 

Signed-off-by: Jessica Frazelle <acidburn@docker.com>

@tianon

@tianon

jessfraz pushed a commit that referenced this pull request

Aug 21, 2015 
docker 1.8+ no longer needs dind

@jessfraz jessfraz deleted the hack-dind-its-been-fun branch

August 21, 2015 20:51

tianon added a commit to docker-library/docker that referenced this pull request

Aug 22, 2015

@lox lox mentioned this pull request

Aug 26, 2015

This was referenced

Sep 3, 2015