Moved "Memory", "MemorySwap" and "CpuShares" mappings from ContainerConfig to HostConfig by Khva0 · Pull Request #291 · docker-java/docker-java
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 1.1k
Conversation
It is compatible with 1.18 and current 1.19 API. And README.md says that docker-java supports Docker Remote API v1.19, Docker Server version 1.7.x.
We either break current API compatibility or break old API compatibility. Docker-java declares compatibility with current API, thus choice is obvious.
Whoever wants to use obsolete Docker version can use older version of Docker-java. Current Docker-java should work on current Docker.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use Long without default
I just moved few fields and corresponding getters from one class to another to comply with changes in docker API. And i did it respecting existing code conventions regarding primitives and default values.
While trying to merge this PR I found other inconsistencies regarding HostConfig object. Sadly the remote API documentation seems to be out of sync with the current implementation...
marcuslinke added a commit that referenced this pull request
Aug 26, 2015This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters