Home Original page

Fix repository name validation errors by marcuslinke · Pull Request #298 · docker-java/docker-java

@marcuslinke

KostyaSha

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe short RepoNameMaxLength?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable names are taken from docker sources. I would like to keep them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😟

@KostyaSha

Do you have any generic Object that can parse, store and provide parts of this data in getters like getTag, getHost, getDigest?

 "proto://url:port/imagename:tag" (or digest)

@marcuslinke

Sadly no. But as already said in another post all this name handling classes needs to be refactored. It's on my todo list, but I'm quite busy to fix bugs atm.

@KostyaSha

@marcuslinke no problems, all this partial classes periodically confuses TODO rework it is good idea

marcuslinke added a commit that referenced this pull request

Aug 18, 2015

@marcuslinke marcuslinke changed the title Fix issue #290 Fix repository name validation errors

Aug 18, 2015

@KostyaSha

@marcuslinke it maybe good idea squashing such minor changes during merge to have better commit/blame history. I usually comparing docker-api docs, docker-java changes and docker client so it difficult sometimes jumping on styling commits

@KostyaSha