Respect exception rules in .dockerignore file while build images by marcuslinke · Pull Request #301 · docker-java/docker-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@marcuslinke

Copy link

Contributor

Respect exception rules like "!Dockerfile" in .dockerignore file while building images. See https://docs.docker.com/reference/builder/#dockerignore-file for details.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo echo?

Copy link

Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@KostyaSha

Copy link

Member

Don't know details, but change LGTM
Squash && 🐑 it?

@marcuslinke

Copy link

Contributor Author

I tried to squash it but did something wrong. Changes are in master now but contained in a new commit, so I will close this PR. OK?

@KostyaSha

Copy link

Member

I usually do rebase -i HEAD~5' and then mark as f (fixup) all commits that i want squash with previous, then force push

@KostyaSha

Copy link

Member

I don't see commits in master, just merge this PR?

marcuslinke added a commit that referenced this pull request

Aug 19, 2015
Respect exception rules in .dockerignore file while build images

@marcuslinke marcuslinke merged commit 0df1b12 into master

Aug 19, 2015

@marcuslinke

Copy link

Contributor Author

Hmmm. Merge contains no changes. However, next time i will be more carefully. Commit is here: 33fdd71

@KostyaSha

Copy link

Member

It is, GH sort history by date. And if there is no changes in PR (i.e. merged in other way) GH automatically detect it and marks as merged/closed.

@marcuslinke marcuslinke deleted the issue-286 branch

August 28, 2015 19:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcuslinke @KostyaSha