Respect exception rules in .dockerignore file while build images by marcuslinke · Pull Request #301 · docker-java/docker-java
Navigation Menu
{{ message }}
docker-java / docker-java Public
- Notifications You must be signed in to change notification settings
- Fork 1.1k
Merged
Respect exception rules in .dockerignore file while build images#301
marcuslinke merged 3 commits intomasterfrom
Respect exception rules in .dockerignore file while build images#301
marcuslinke merged 3 commits intomasterfrom
Conversation
Copy link
Contributor
marcuslinke
commented
Aug 19, 2015
marcuslinke
commented
Respect exception rules like "!Dockerfile" in .dockerignore file while building images. See https://docs.docker.com/reference/builder/#dockerignore-file for details.
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
echo echo?
Copy link
Contributor Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thanks!
Marcus Linke added 2 commits
August 19, 2015 23:42Copy link
Member
KostyaSha
commented
Aug 19, 2015
KostyaSha commented
Aug 19, 2015Don't know details, but change LGTM
Squash && 🐑 it?
Copy link
Contributor Author
marcuslinke
commented
Aug 19, 2015
marcuslinke commented
Aug 19, 2015I tried to squash it but did something wrong. Changes are in master now but contained in a new commit, so I will close this PR. OK?
Copy link
Member
KostyaSha
commented
Aug 19, 2015
KostyaSha commented
Aug 19, 2015I usually do rebase -i HEAD~5' and then mark as f (fixup) all commits that i want squash with previous, then force push
Copy link
Member
KostyaSha
commented
Aug 19, 2015
KostyaSha commented
Aug 19, 2015I don't see commits in master, just merge this PR?
marcuslinke added a commit that referenced this pull request
Aug 19, 2015Respect exception rules in .dockerignore file while build images
marcuslinke
merged commit
0df1b12
into
master
Copy link
Contributor Author
marcuslinke
commented
Aug 19, 2015
marcuslinke commented
Aug 19, 2015Hmmm. Merge contains no changes. However, next time i will be more carefully. Commit is here: 33fdd71
Copy link
Member
KostyaSha
commented
Aug 19, 2015
KostyaSha commented
Aug 19, 2015It is, GH sort history by date. And if there is no changes in PR (i.e. merged in other way) GH automatically detect it and marks as merged/closed.
marcuslinke
deleted the
issue-286
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment