Home Original page

Adding support for withPidMode #332 by sashkachan · Pull Request #333 · docker-java/docker-java

@sashkachan

KostyaSha

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcuslinke do you need at all this huge constructor?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Not needed. It's already removed in 'issue-246' branch. So no need to remove it here.

Aleksandr Guljajev added 2 commits

September 28, 2015 17:12

KostyaSha

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CheckForNull here also required as it doesn't inherited by any interfaces

@sashkachan

I think all issues but humongous constructor were addressed. Let me know if I missed anything.
Thanks.

@marcuslinke

Thanks for your contribution! Hopefully I'm able to merge this evening.

mwl

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to reflect the CLI, it should be withPid(String pidMode):

  --pid=                          PID namespace to use

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks.