Home Original page

Introduce InspectContainerResponse.Mounts by marcuslinke · Pull Request #392 · docker-java/docker-java

@marcuslinke

KostyaSha

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be changed to RemoteApiVersion object?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make sense. Will do as suggested.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems thats not that simple. RemoteApiVersion is not used by DockerClientConfigBuilder so far. So leaving this for separate PR.

KostyaSha

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like it should be RW and RO (upper case)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops. I fear it's too late now. This one must be a String.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, maybe better AssertThat(..., equalTo(...)) ?

Marcus Linke added 3 commits

December 7, 2015 23:18

marcuslinke added a commit that referenced this pull request

Dec 8, 2015 
Introduce InspectContainerResponse.Mounts