Support for volume API by marcuslinke · Pull Request #408 · docker-java/docker-java
Marcus Linke added 2 commits
December 18, 2015 22:29Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line
@marcuslinke have you successfully run build locally with static analysing profile enabled? :)
@KostyaSha Sorry, what do you mean. Doesn't a simple mvn clean install should be sufficient?
@marcuslinke install will pollute your local repo :) mvn -Pdocker-java-analysis package or just mvn package (because profile is enabled by default) should be enough if you didn't disable profile in your ide. But probably checkstyle doesn't contain new line check. In general having new lines in the end of file is good tone (starting from time when NL was expected as end of stream/resource) and excludes red icon.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add javadoc when apparead? 1.21?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do myself later.
Is travis building merged state? let's check.
Sorry, merge conflict. Hoped that it wouldn't.
Added NL in missed file, fixuped two commits in one, merged manually to master.
This PR is really merged into master via 899f7ba .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters