Add aux to ResponseItem for API 1.22 by marcust · Pull Request #442 · docker-java/docker-java
Navigation Menu
{{ message }}
docker-java / docker-java Public
- Notifications You must be signed in to change notification settings
- Fork 1.1k
Closed
marcust wants to merge 1 commit intodocker-java:masterfrom
Closed
Add aux to ResponseItem for API 1.22#442
marcust wants to merge 1 commit intodocker-java:masterfrom
Add aux to ResponseItem for API 1.22#442
marcust wants to merge 1 commit intodocker-java:masterfrom
Conversation
marcust pushed a commit to alexec/docker-java-orchestration that referenced this pull request
Jan 28, 2016Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please set since javadocs tags
Copy link
Contributor
marcuslinke
commented
Jan 29, 2016
marcuslinke commented
Jan 29, 2016@marcust Thanks. Will merge after v3.0.0 is released.
As mentioned in Issue docker-java#437
marcust
force-pushed
the
feature/add_aux_response
branch
from
a3d58c6 to
286731a
Compare
marcuslinke
added
the
API/1.22
label
marcuslinke
added this to the
3.1.0 milestone
Copy link
Member
KostyaSha
commented
Feb 7, 2016
KostyaSha commented
Feb 7, 2016@marcuslinke as soon as you end your refactorings i plan resolve #404 with reviewing newer API. Let me know when you end.
|
|
||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| public static class AuxDetail implements Serializable { | ||
| private static final long serialVersionUID = -9136704865403084084L; |
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy link
Member
KostyaSha
commented
Feb 16, 2016
KostyaSha commented
Feb 16, 2016I will pick this into 1.22 branch. I think i we will keep it open until all tests will be added before real master merge.
KostyaSha
self-assigned this
KostyaSha
mentioned this pull request
Closed
Copy link
Member
KostyaSha
commented
Mar 10, 2016
KostyaSha commented
Mar 10, 2016Can't reproduce "aux" field on 1.10.2 daemon...
Copy link
Member
KostyaSha
commented
Mar 10, 2016
KostyaSha commented
Mar 10, 2016maybe it only on secured daemons https://github.com/docker/docker/blob/2892de760f412360c5effef9cfc346f2d92eaa4c/pkg/progress/progress.go#L19-L21
KostyaSha
mentioned this pull request
Copy link
Member
KostyaSha
commented
Mar 10, 2016
KostyaSha commented
Mar 10, 2016@marcust could you provide some dump of this pull response?
KostyaSha
modified the milestones:
3.0.0,
3.1.0
Copy link
Member
KostyaSha
commented
Mar 10, 2016
KostyaSha commented
Mar 10, 2016Merged, but json sample would be welcome!
KostyaSha
closed this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants