Expose cgroup-parent to the client by mavant · Pull Request #495 · docker-java/docker-java

@mavant

This change is Review on Reviewable

@codecov-io

Current coverage is 21.60%

Merging #495 into master will decrease coverage by -0.01% as of 0a072e1

@@            master   #495   diff @@
=====================================
  Files          290    290       
  Stmts         5944   5948     +4
  Branches       527    527       
  Methods          0      0       
=====================================
  Hit           1285   1285       
  Partial         83     83       
- Missed        4576   4580     +4

Review entire Coverage Diff as of 0a072e1

Powered by Codecov. Updated on successful CI builds.

@mavant

@KostyaSha

Starting from what API version does it appeared?

@mavant

@KostyaSha

please check the master code and version, we hope release it soon...

@mavant

I'm not sure I understand, can you rephrase?

@KostyaSha

Sorry, i thought it targeted to 2.x branch.

@mavant

Ah, I see. Nope, newer is better I always say :)

@KostyaSha

Seems hostconfig is also missing properties :(

@KostyaSha

Ah, no, no way to serder CMDs :(

@KostyaSha

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io