Home Original page

Implement container rename api by lujian0571 · Pull Request #504 · docker-java/docker-java

@lujian0571

@lujian0571

KostyaSha

/**
* rename a container.
*
* Created by lujian on 16/3/16.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use @author javadoc without the date

@codecov-io

Current coverage is 22.81%

Merging #504 into master will decrease coverage by -0.11% as of 11f0e80

@@            master    #504   diff @@
======================================
  Files          291     294     +3
  Stmts         6042    6071    +29
  Branches       527     527       
  Methods          0       0       
======================================
  Hit           1385    1385       
  Partial         83      83       
- Missed        4574    4603    +29

Review entire Coverage Diff as of 11f0e80

Powered by Codecov. Updated on successful CI builds.

KostyaSha

try {
dockerClient.restartContainerCmd("non-existing").exec();
fail("expected NotFoundException");
} catch (NotFoundException e) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have expected test annotation

@KostyaSha

Please check when this method appeared and mark it in javadoc for cmds.

KostyaSha

import javax.annotation.Nonnull;

/**
* rename a container.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start with capital letter :)

@KostyaSha

Thanks, i will handle this pr on weekend.

@KostyaSha

@KostyaSha