Added shmsize build option by alemousist · Pull Request #533 · docker-java/docker-java

@alemousist

Added shmsize (Size of /dev/shm in bytes) on imagebuild as described in Docker API 1.22


This change is Reviewable

@codecov-io

Current coverage is 23.68%

Merging #533 into master will decrease coverage by -0.03% as of e4bb095

@@            master    #533   diff @@
======================================
  Files          295     295       
  Stmts         6102    6109     +7
  Branches       530     532     +2
  Methods          0       0       
======================================
  Hit           1447    1447       
  Partial         85      85       
- Missed        4570    4577     +7

Review entire Coverage Diff as of e4bb095

Powered by Codecov. Updated on successful CI builds.

@KostyaSha

@alemousist

@KostyaSha ,
The shmsize option appeared in the latest version (v1.22) of the remote api.
I've adapted code to the project code style/design.
Thanks!

@marcuslinke

@KostyaSha

@marcuslinke

Integration test will be difficult... How this could be tested?

@KostyaSha

@marcuslinke

@KostyaSha This field is not serialized to json, so serder test will not work.

@KostyaSha

You have the field and it sends to docker daemon as request. Url parameter is only untestable without integration.

@marcuslinke

Sorry, not sure what you mean...

@KostyaSha

@marcuslinke all *Cmd classes corresponds to request objects. For docker daemon result of *cmd execution is just json (request) that sent to daemon. You can dump it and i want serialise/deserialise request data to class directly. Atm i can't do this because all *Cmd classes has constructor, because cmd contains request data and execution logic (code that do request). As i understand initially in this library *Cmd was only the execution method that allowed set request data.
Tied data to request code allows make fluent and shorter library calls.

@KostyaSha

panuse pushed a commit to TuKangTech/docker-java that referenced this pull request

Aug 20, 2017
Added shmsize build option