Fix issue #1461- use a recommended dh group instead of a self-generated one by youtous · Pull Request #1463 · docker-mailserver/docker-mailserver

@youtous changed the title Pr fix dhe Fix issue #1461- use a recommended dh group instead of a self-generated one

Apr 22, 2020

polarathene

@youtous youtous marked this pull request as ready for review

April 26, 2020 20:11

@youtous

use by default ffdhe4096 for DHE params 


use by default ffdhe4096 for DHE params

@youtous

@youtous

@youtous

polarathene

@youtous

@youtous

polarathene

Co-Authored-By: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
Co-Authored-By: Brennan Kinney <5098581+polarathene@users.noreply.github.com>
Co-Authored-By: Brennan Kinney <5098581+polarathene@users.noreply.github.com>

polarathene

polarathene added a commit to polarathene/docker-mailserver that referenced this pull request

Sep 14, 2021
This feature was introduced by the PR: docker-mailserver#1463

There is no official documented support for custom DH parameters. As no guarantee is provided, this is considered an internal change, not a breaking one.

There is no apparent need for special handling with `ONE_DIR=1`.

polarathene added a commit that referenced this pull request

Sep 15, 2021
This feature was originally introduced by the PR: #1463

- Assign default DH params to use via Dockerfile build instead of copy and update at runtime.
- Parameterized service names and paths.
- Refactor postfix and dovecot dh methods to wrap shared dh logic
- I don't see any value in checking the alternative service for dh params file to copy over, so that's now dropped too.
- Another conditional check is dropped and the default fallback message for existing DH params file is no longer relevant.
- Improved the remaining `_notify` messages. Collapsing the warning into a single logged message also seemed relevant.
- There is no apparent need for special handling with `ONE_DIR=1`. Dropped it.

- Refactor DH params  tests
- Combine custom and default DH param tests into single test file
- docs: Add instructions to use custom DH params

There is no official documented support for custom DH parameters. As no guarantee is provided, this is considered an internal change, not a breaking one.