Add support for # in cache key; add test. by demiankatz · Pull Request #809 · doctrine/DoctrineModule
Navigation Menu
{{ message }}
doctrine / DoctrineModule Public
- Notifications You must be signed in to change notification settings
- Fork 262
Merged
TomHAnderson merged 1 commit intodoctrine:6.0.xfrom
Jun 9, 2023Merged
Add support for # in cache key; add test.#809
TomHAnderson merged 1 commit intodoctrine:6.0.xfrom
Add support for # in cache key; add test.#809
TomHAnderson merged 1 commit intodoctrine:6.0.xfrom
Conversation
Copy link Copy Markdown
Contributor
demiankatz
mentioned this pull request
demiankatz
force-pushed
the
more-cache-improvements
branch
from
3c971d0 to
e991da3
Compare
demiankatz
force-pushed
the
more-cache-improvements
branch
from
e991da3 to
9eea9a7
Compare
Copy link Copy Markdown
Contributor Author
demiankatz
commented
Jun 9, 2023
demiankatz commented
Jun 9, 2023This should be ready for merge, @TomHAnderson, unless @Novynn is aware of any additional characters that should be added to the regex and corresponding test.
TomHAnderson approved these changes Jun 9, 2023
Copy link Copy Markdown
Member
TomHAnderson
left a comment
TomHAnderson
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this because it's certainly broken. More testing of individual adapters is in order.
TomHAnderson
merged commit
b7b08fd
into
doctrine:6.0.x
demiankatz
deleted the
more-cache-improvements
branch
Copy link Copy Markdown
Contributor Author
demiankatz
commented
Jun 9, 2023
demiankatz commented
Jun 9, 2023If further followup is needed, I'm happy to help, time permitting. I hope to spend some time in the next couple of weeks integrating this into my own application, so hopefully that will help turn up any remaining issues!
TomHAnderson
added this to the
6.0.3 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants