Add function to create "typed" version of middleware by agubler · Pull Request #819 · dojo/framework
Conversation
Type: bug
The following has been addressed in the PR:
- There is a related issue
- All code has been formatted with
prettieras per the readme code style guidelines - Unit or Functional tests are included in the PR
Description:
When factories are used to create middleware to print typings we don't need to actually create the middleware-factory every time, only stamp the type on the returned middleware-factory type.
Resolves #817
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit a859a31:
| Sandbox | Source |
|---|---|
| dojo/dojo-codesandbox-template | Configuration |
agubler
changed the title
WIP: Use statically defined middleware for resource and icache
Add function to create "typed" version of middleware
tomdye pushed a commit to tomdye/framework that referenced this pull request
Sep 23, 2020tomdye added a commit that referenced this pull request
Sep 23, 2020* Handle ignored children in decorate (#840) * Allow finding and modifying wrapped widgets in functional children (#780) * Add function to create "typed" version of middleware (#819) * Add factory function to middleware for adding types * change to withType * Fix mock middleware types (#822) * Wrap children result in an array if not already in one (#844) * wrap children result in an array if not already in one * add test for wrapped children * update assert render unit test (#820) Co-authored-by: Bradley Maier <bmaier@sitepen.com> Co-authored-by: Anthony Gubler <agubler@sitepen.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters