Add function to create "typed" version of middleware by agubler · Pull Request #819 · dojo/framework

Conversation

@agubler

Type: bug

The following has been addressed in the PR:

Description:

When factories are used to create middleware to print typings we don't need to actually create the middleware-factory every time, only stamp the type on the returned middleware-factory type.

Resolves #817

@codesandbox-ci

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a859a31:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@agubler agubler changed the title WIP: Use statically defined middleware for resource and icache Add function to create "typed" version of middleware

Jul 20, 2020

matt-gadd

@codecov

tomdye pushed a commit to tomdye/framework that referenced this pull request

Sep 23, 2020
* Add factory function to middleware for adding types

* change to withType

tomdye added a commit that referenced this pull request

Sep 23, 2020
* Handle ignored children in decorate (#840)

* Allow finding and modifying wrapped widgets in functional children (#780)

* Add function to create "typed" version of middleware (#819)

* Add factory function to middleware for adding types

* change to withType

* Fix mock middleware types (#822)

* Wrap children result in an array if not already in one (#844)

* wrap children result in an array if not already in one

* add test for wrapped children

* update assert render unit test (#820)

Co-authored-by: Bradley Maier <bmaier@sitepen.com>
Co-authored-by: Anthony Gubler <agubler@sitepen.com>

Labels

2 participants

@agubler @matt-gadd