Add tests for [UnsafeAccessor] on fields with readonly by Sergio0694 · Pull Request #109944 · dotnet/runtime

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Sergio0694

Copy link

Contributor

@Sergio0694 Sergio0694 commented

Nov 19, 2024

edited

Loading

Closes #109943

Follow up to #109694, adds some tests to cover #109943 too, just in case.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution

Indicates that the PR has been added by a community member

label

Nov 19, 2024
Copy link

Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sergio0694 reacted with heart emoji

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit cae0e0f into dotnet:main

Nov 19, 2024

@Sergio0694 Sergio0694 deleted the user/sergiopedri/readonly-accessor-tests branch

November 19, 2024 06:05

mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request

Dec 10, 2024

@github-actions github-actions bot locked and limited conversation to collaborators

Dec 19, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees

No one assigned

Labels

area-System.Runtime.CompilerServices community-contribution

Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[UnsafeAccessor] throws MissingFieldException on .NET 9 when used on unspeakable fields

2 participants

@Sergio0694 @AaronRobinsonMSFT