[BrowserDebugProxy] Remove exception details from error report by mdh1418 · Pull Request #111169 · dotnet/runtime
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 5.4k
Merged
mdh1418 merged 2 commits intodotnet:mainfrom
Jan 8, 2025Merged
[BrowserDebugProxy] Remove exception details from error report#111169
mdh1418 merged 2 commits intodotnet:mainfrom
[BrowserDebugProxy] Remove exception details from error report#111169
mdh1418 merged 2 commits intodotnet:mainfrom
Conversation
Copy link
Member
We don't need to send the exception details in the error report. Remove the information as we can just grab the count.
Associated PR: microsoft/vscode-js-debug#2158
mdh1418
requested review from
hoyosjs and
tommcdon
mdh1418
requested review from
ilonatommy and
thaystg
as code owners
ghost
added
the
area-Debugger-mono
label
dotnet-policy-service
bot
assigned
mdh1418
Copy link
Contributor
dotnet-policy-service
bot
commented
Jan 7, 2025
dotnet-policy-service bot commented
Jan 7, 2025Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.
tommcdon approved these changes Jan 7, 2025
mdh1418
force-pushed
the
browser_debug_proxy_expression_evaluation_count
branch
from
bb5091c to
7fdea01
Compare
mdh1418
force-pushed
the
browser_debug_proxy_expression_evaluation_count
branch
from
7fdea01 to
237b757
Compare
mdh1418
requested a review
from tommcdon
thaystg approved these changes Jan 7, 2025
mdh1418
force-pushed
the
browser_debug_proxy_expression_evaluation_count
branch
from
e7198ce to
e63fe9e
Compare
Copy link
Member
thaystg
commented
Jan 7, 2025
thaystg commented
Jan 7, 2025I think we can backport it for .NET 9 also.
mdh1418
mentioned this pull request
tommcdon approved these changes Jan 8, 2025
Copy link
Member
tommcdon
left a comment
tommcdon
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mdh1418
merged commit
b054be3
into
dotnet:main
Copy link
Member Author
mdh1418
commented
Jan 8, 2025
mdh1418 commented
Jan 8, 2025/backport to release/9.0-staging
Copy link
Contributor
github-actions
bot
commented
Jan 8, 2025
github-actions bot commented
Jan 8, 2025Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12674606859
github-actions
bot
mentioned this pull request
4 tasks
github-actions
bot
locked and limited conversation to collaborators
mdh1418
deleted the
browser_debug_proxy_expression_evaluation_count
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.