Handle OSSL 3.4 change to SAN:othername formatting by bartonjs · Pull Request #111820 · dotnet/runtime
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/libraries/System.Security.Cryptography/tests/AsnEncodedDataTests.cs:121
- The error message string contains double colons '::' which seems to be a typo. It should be 'othername: UPN:subjectupn1@example.org'.
isOpenSsl3 ? "othername: UPN::subjectupn1@example.org" : "othername:<unsupported>",
This was referenced
Jan 25, 2025
For what it's worth, the commit / PR title mention SAN, but this is for UPN.
Okay never mind. It's the UPN in the SAN.
/backport to release/9.0-staging
/backport to release/8.0-staging
github-actions
bot
locked as resolved and limited conversation to collaborators
8.0 backport failed, but it didn't make a comment because the 9.0 re-locked the PR before 8.0 finished running.
I'll do 8.0 manually in a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters