[browser] Remove experimental args from NodeJS WBT runner (part2) by maraf · Pull Request #113753 · dotnet/runtime

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@maraf

Copy link

Member

@maraf maraf commented

Mar 21, 2025

edited

Loading

Remove args from 1 missed test from #111655.
Contributes to #111753

@maraf maraf added arch-wasm

WebAssembly architecture

area-Infrastructure-mono os-browser

Browser variant of arch-wasm

labels

Mar 21, 2025

@maraf maraf added this to the 9.0.x milestone

Mar 21, 2025

@maraf maraf self-assigned this

Mar 21, 2025

Copilot AI review requested due to automatic review settings

March 21, 2025 07:53

@maraf maraf requested a review from ilonatommy as a code owner

March 21, 2025 07:53
Copy link

Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes experimental arguments from the NodeJS WebAssembly test runner to align with the updates from a previous PR.

  • Removes experimental SIMD and exception handling engine arguments for NodeJS in WasmSIMDTests.cs.

@maraf

Copy link

Member Author

maraf commented

Mar 21, 2025

Infrastructure-only change, tell mode, applying servicing-approved.

@maraf maraf added the Servicing-approved

Approved for servicing release

label

Mar 21, 2025

@dotnet-policy-service

Copy link

Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak
See info in area-owners.md if you want to be subscribed.

@maraf

Copy link

Member Author

maraf commented

Mar 24, 2025

/ba-g Failures are not related

@maraf maraf merged commit bb1ff11 into release/9.0-staging

Mar 24, 2025

27 of 33 checks passed

@maraf maraf deleted the maraf/BrowserWbtNoExperimentalNodeJS2 branch

March 24, 2025 12:26

@github-actions github-actions bot locked and limited conversation to collaborators

Apr 24, 2025

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@ilonatommy ilonatommy ilonatommy approved these changes

Assignees

@maraf maraf

Labels

arch-wasm

WebAssembly architecture

area-Infrastructure-mono os-browser

Browser variant of arch-wasm

Servicing-approved

Approved for servicing release

Projects

None yet

Milestone

9.0.x

Development

Successfully merging this pull request may close these issues.

3 participants

@maraf @ilonatommy