Disable odbc tests on net9 interpreter by BrzVlad · Pull Request #117245 · dotnet/runtime
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 5.4k
Conversation
Copilot AI review requested due to automatic review settings
July 2, 2025 15:18
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables a set of ODBC integration tests on the Mono interpreter (net9) by marking them with an ActiveIssue attribute.
- Adds
[ActiveIssue(..., PlatformDetection.IsMonoInterpreter)]to individual test methods. - Targets tests across multiple files to skip them until issue #116482 is addressed.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/libraries/System.Data.Odbc/tests/SmokeTest.cs | Marked CreateInsertSelectTest with ActiveIssue |
| src/libraries/System.Data.Odbc/tests/ReaderTests.cs | Added ActiveIssue to several reader-related test methods |
| src/libraries/System.Data.Odbc/tests/DependencyCheckTest.cs | Marked dependency-check test with ActiveIssue |
| src/libraries/System.Data.Odbc/tests/ConnectionTests.cs | Added ActiveIssue to connection test |
| src/libraries/System.Data.Odbc/tests/CommandBuilderTests.cs | Marked command-builder tests with ActiveIssue |
@ericstj @akoeplinger This is just for green CI on .net9. What would be the process with this ? Does it need to go through normal tactics approval like normal fixes ?
Test-only changes are tell-mode.
This was referenced
Aug 5, 2025This was referenced
Aug 7, 2025This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters