Fix bug in dump() caused by incorrectly passing args to dumps() by pastelmind · Pull Request #35 · dpranke/pyjson5
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 34
Merged
Fix bug in dump() caused by incorrectly passing args to dumps()#35
dpranke merged 1 commit intodpranke:masterfrom
pastelmind:bugfix/dump-args
Fix bug in dump() caused by incorrectly passing args to dumps()#35
dpranke merged 1 commit intodpranke:masterfrom
pastelmind:bugfix/dump-args
Conversation
Copy link
Contributor
pastelmind
commented
Mar 13, 2020
pastelmind
commented
dump() was broken because it wasn't passing the cls parameter to dumps(). I fixed it and also made it pass all arguments using keywords, which should help prevent similar bugs if dumps() learns new keyword arguments in the future.
Fix a bug (caused by a missing cls) that caused dump() to pass arguments to dumps() incorrectly.
Copy link
Owner
dpranke
commented
Mar 17, 2020
dpranke commented
Mar 17, 2020Oops. Thanks for the fix!
dpranke
merged commit
d0897c8
into
dpranke:master
pastelmind
deleted the
bugfix/dump-args
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants