Home Original page

Added Java 8 InstantParam with test. by lightswitch05 · Pull Request #2048 · dropwizard/dropwizard

@lightswitch05

Some java 8 users might want to avoid Joda-Time in favor of Instant

@coveralls

Coverage Status

Coverage increased (+0.01%) to 84.535% when pulling 53d78e5 on lightswitch05:feature/instant-param into cebf1d6 on dropwizard:master.

joschi

import java.time.ZoneOffset;
import java.time.LocalDateTime;

/**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the @author tag (or rather the complete Javadoc comment).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that one, editor added it automatically.

/**
* @author Daniel White
*/
public class InstantParamTest {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case for bad input.

@coveralls

Coverage Status

Coverage decreased (-0.01%) to 84.51% when pulling 8710100 on lightswitch05:feature/instant-param into cebf1d6 on dropwizard:master.

@lightswitch05

@coveralls

Coverage Status

Coverage increased (+0.03%) to 84.551% when pulling ccf006c on lightswitch05:feature/instant-param into cebf1d6 on dropwizard:master.

@lightswitch05

@joschi I made the requested changes, let me know if it needs more work

joschi

@joschi

aaanders pushed a commit to aaanders/dropwizard that referenced this pull request

Sep 20, 2018

@lightswitch05