[23573] Add blackbox tests for original writer info in ddspipe by emiliocuestaf · Pull Request #525 · eProsima/DDS-Router
Adds a blackbox test that checks that:
- dds-pipe sets the original writer when the original writer is unknown
- dds-pipe keeps the original writer when it is known
This PR depends on eProsima/DDS-Pipe#163 and must be merged after it.
cferreiragonz
changed the title
[23573] Refs #23573, add blackbox tests for original writer info in ddspipe
[23573] Add blackbox tests for original writer info in ddspipe
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can swap case 2 and case 3. In this way the expected value on the subscriber side will change between the three tested cases. Right now, case 1 and case 2 will generate the same value and it might occur that the value is not updated but the test does not report it.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.24%. Comparing base (4f70d05) to head (64353c9).
⚠️ Report is 3 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #525 +/- ## ========================================== - Coverage 31.14% 30.24% -0.90% ========================================== Files 16 16 Lines 594 562 -32 Branches 321 298 -23 ========================================== - Hits 185 170 -15 + Misses 213 205 -8 + Partials 196 187 -9
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters