Always send `begin` work done progress before sending `end` by mfussenegger · Pull Request #2258 · eclipse-jdtls/eclipse.jdt.ls

@mfussenegger

Clients like neovim show an error message if `end` is received for a
token without having received a corresponding `begin`.

The specification also requires it:

> To start progress reporting a $/progress notification with the following payload must be sent

This ensures `begin` is always sent first and also avoids creating
intermediate `ProgressReport` instances.

@mfussenegger marked this pull request as ready for review

September 30, 2022 19:50

@mfussenegger

rmuir added a commit to rmuir/nvim-lspconfig that referenced this pull request

Sep 10, 2025

@rmuir rmuir mentioned this pull request

Sep 10, 2025

justinmk pushed a commit to neovim/nvim-lspconfig that referenced this pull request

Sep 11, 2025
Problem:
The nonstandard progress handler was added in #2153 but it can cause
some undesirable side-effects out of box ("press enter").
The original bug (mfussenegger/nvim-jdtls#327) was fixed upstream in the
language server three years ago (eclipse-jdtls/eclipse.jdt.ls#2258).

Solution:
Remove the workaround. Standard progress works.