fix allOf in array by LukasBoll · Pull Request #2053 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@LukasBoll

Copy link

Contributor

No description provided.

@sdirix sdirix requested a review from TheZoker

November 29, 2022 08:56

@coveralls

Copy link

Coverage Status

Coverage remained the same at 83.38% when pulling 3331029 on LukasBoll:fixAllOfInArray into 91f351d on eclipsesource:master.

Copy link

Contributor

@TheZoker TheZoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can confirm that the change work with the example from the issue:
image

Copy link

Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdirix sdirix merged commit 506c098 into eclipsesource:master

Jan 2, 2023

@sdirix sdirix linked an issue

Jan 2, 2023

that may be closed by this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

+1 more reviewer

@TheZoker TheZoker TheZoker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Custom error message with Ajv-errors on nested schema

4 participants

@LukasBoll @coveralls @TheZoker @sdirix