fix toDataPath function comment explaining correct functionality by jlarrubiaq · Pull Request #2061 · eclipsesource/jsonforms
Navigation Menu
{{ message }}
eclipsesource / jsonforms Public
- Notifications You must be signed in to change notification settings
- Fork 421
Merged
sdirix merged 1 commit intoeclipsesource:masterfrom
Jan 2, 2023Merged
fix toDataPath function comment explaining correct functionality#2061
sdirix merged 1 commit intoeclipsesource:masterfrom
fix toDataPath function comment explaining correct functionality#2061
sdirix merged 1 commit intoeclipsesource:masterfrom
Conversation
Copy link
Contributor
jlarrubiaq
commented
Dec 7, 2022
jlarrubiaq
commented
I found the explanation of what toDataPath does is not correct. The new comment reflects the actual functionality.
Copy link
All committers have signed the CLA.
sdirix requested changes Dec 8, 2022
Copy link
Member
sdirix
left a comment
sdirix
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
packages/core/src/util/path.ts
Outdated
Show resolved
Hide resolved
packages/core/src/util/path.ts Outdated Show resolved Hide resolved
jlarrubiaq
force-pushed
the
patch-1
branch
from
abae7e0 to
557e3a5
Compare
Copy link
coveralls
commented
Dec 8, 2022
coveralls commented
Dec 8, 2022
Copy link
Contributor Author
jlarrubiaq
commented
Dec 13, 2022
jlarrubiaq commented
Dec 13, 2022@sdirix I addressed your comment. Thanks!
sdirix approved these changes Jan 2, 2023
Copy link
Member
sdirix
left a comment
sdirix
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution
sdirix
added this to the
3.1 milestone
sdirix
merged commit
ef9305a
into
eclipsesource:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants