propagate readOnly prop in Angular detail-List by LukasBoll · Pull Request #2062 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@LukasBoll

Copy link

Contributor

closes #1479

@coveralls

Copy link

Coverage Status

Coverage decreased (-0.2%) to 83.193% when pulling 1376f3b on LukasBoll:angularReadOnlyArrayRenderer into 96be520 on eclipsesource:master.

Copy link

Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sdirix sdirix merged commit 3b32c9b into eclipsesource:master

Jan 5, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[angular] table does not correctly propagate read-only state to children

3 participants

@LukasBoll @coveralls @sdirix