Use type only imports by wienczny · Pull Request #2076 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@wienczny

Copy link

Contributor

Use type only imports supported since TS 3.8+ to improve module isolation.

https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-8.html

@netlify

Copy link

netlify bot commented

Jan 11, 2023

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 8c1a657
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/63beed760d99b900091d3c0d
😎 Deploy Preview https://deploy-preview-2076--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site settings.

@sdirix

Copy link

Member

sdirix commented

Jan 17, 2023

@wienczny Thanks for the contribution!

@coveralls

Copy link

Coverage Status

Coverage: 83.193%. Remained the same when pulling 8c1a657 on wienczny:importsNotUsedAsValues into 36e3732 on eclipsesource:master.

Copy link

Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me! Thanks!

wienczny reacted with thumbs up emoji

@sdirix sdirix merged commit bd4141c into eclipsesource:master

Jan 23, 2023

@sdirix sdirix added this to the 3.1 milestone

Jan 23, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@wienczny @sdirix @coveralls