array translatins for vanilla, angular-material and vue by LukasBoll · Pull Request #2129 · eclipsesource/jsonforms
Add translation-options for array-control elements for the vanilla, angular-material and vue renderers.
closes #1826
@lucas-koehler Do you have any idea why the Angular Material tests are failing
Thank you @lucas-koehler, @sdirix,
I looked at the tests again this afternoon and I just found the issues; A module-import was missing in the testing Module! And the aria-label attribute needs to be assigned another way, then I did. I will update the PR today!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes in the renderers look already pretty good to me, thanks :)
There are various test cases failing. They are failing consistently on both Windows and Ubuntu. Note that the MacOS build succeeds because it does not execute tests.
It seems that the tests fail because elements are not found. This is likely caused by the changes to the aria labels in packages/core/src/i18n/arrayTranslations.ts because the tests use aria label attributes to find the buttons.
Thus, you need to adapt the tests to the changed aria label texts.
LukasBoll
changed the title
WIP: array translatins for vanilla, angular-material and vue
array translatins for vanilla, angular-material and vue
Code changes in the renderers look already pretty good to me, thanks :)
There are various test cases failing. They are failing consistently on both Windows and Ubuntu. Note that the MacOS build succeeds because it does not execute tests.
It seems that the tests fail because elements are not found. This is likely caused by the changes to the aria labels in
packages/core/src/i18n/arrayTranslations.tsbecause the tests use aria label attributes to find the buttons. Thus, you need to adapt the tests to the changed aria label texts.
Thank you, I just realized that as well, but now everything should work properly!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for the fixes :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters