array translatins for vanilla, angular-material and vue by LukasBoll · Pull Request #2129 · eclipsesource/jsonforms

@LukasBoll

Add translation-options for array-control elements for the vanilla, angular-material and vue renderers.

closes #1826

@netlify

@sdirix

@lucas-koehler Do you have any idea why the Angular Material tests are failing

@LukasBoll

Thank you @lucas-koehler, @sdirix,
I looked at the tests again this afternoon and I just found the issues; A module-import was missing in the testing Module! And the aria-label attribute needs to be assigned another way, then I did. I will update the PR today!

lucas-koehler

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes in the renderers look already pretty good to me, thanks :)

There are various test cases failing. They are failing consistently on both Windows and Ubuntu. Note that the MacOS build succeeds because it does not execute tests.

It seems that the tests fail because elements are not found. This is likely caused by the changes to the aria labels in packages/core/src/i18n/arrayTranslations.ts because the tests use aria label attributes to find the buttons.
Thus, you need to adapt the tests to the changed aria label texts.

@LukasBoll

@coveralls

Coverage Status

Coverage: 84.703% (+1.5%) from 83.193% when pulling f5db5d0 on LukasBoll:arrayTranslations into ba35fde on eclipsesource:master.

@LukasBoll LukasBoll changed the title WIP: array translatins for vanilla, angular-material and vue array translatins for vanilla, angular-material and vue

Apr 13, 2023

@LukasBoll

Code changes in the renderers look already pretty good to me, thanks :)

There are various test cases failing. They are failing consistently on both Windows and Ubuntu. Note that the MacOS build succeeds because it does not execute tests.

It seems that the tests fail because elements are not found. This is likely caused by the changes to the aria labels in packages/core/src/i18n/arrayTranslations.ts because the tests use aria label attributes to find the buttons. Thus, you need to adapt the tests to the changed aria label texts.

Thank you, I just realized that as well, but now everything should work properly!

lucas-koehler

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for the fixes :)