Upgrade build stack to pnpm, Node 16, Lerna 6 by lucas-koehler · Pull Request #2148 · eclipsesource/jsonforms
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 421
Conversation
- Move to Node 16.13+
- Use PNPM 8.5+ as package manager instead of NPM
- Upgrade to Lerna 6
- Explicitly add all needed dependencies to packages as PNPM does not hoist application dependencies
- Use explicit PNPM workspace references for jsonforms packages
- Increase various dependencies to reflect the actually needed versions
- Migrate to Jest 27
- Increase Typedoc version to ~0.21.9 to be compatible with Node 16
- Increase base lib version from ES6 to ES2016
- Improve stability of prepare example apps script
- BREAKING: Remove vue2 to avoid migration cost
- ci: Increase Node's available RAM for test execution to 4GB
- Set pnpm's dependency resolution to highest compatible (same as npm)
@sdirix The netlify build fails because node 16 and pnpm are not available there, yet.
@sdirix I rebased the changes. Netlify still fails as it does not have pnpm and node 16 configured.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a first look and only very minor comments. As a next step I will actually test it.
Seems the mac tests still fail. So let's exclude them again and create a follow up issue to fix them
- Move to Node 16.13+ - Use PNPM 8.5+ as package manager instead of NPM - Upgrade to Lerna 6 - Explicitly add all needed dependencies to packages as PNPM does not hoist dependencies - Use explicit PNPM workspace references for jsonforms packages - Increase various dependencies as PNPM installs the specified version by default instead of the highest possible one - Migrate to Jest 27 - Increase Typedoc version to ~0.21.9 to be compatible with Node 16 TODO: Fix Setup for the vue packages
Follow up issue to fix the macOS tests: #2159
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me!
sdirix
deleted the
2110-node16-pnpm-lerna6
branch
This was referenced
Jul 11, 2023This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters