remove unsupported operators in angular material object renderer by LukasBoll · Pull Request #2160 · eclipsesource/jsonforms

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@LukasBoll

Copy link

Contributor

remove unsupported operators in angular material object renderer
closes #2083

@netlify

Copy link

netlify bot commented

Jul 11, 2023

edited

Loading

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 8f2d538
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/64c6925210faa600082b8289
😎 Deploy Preview https://deploy-preview-2160--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.


To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls

Copy link

coveralls commented

Jul 11, 2023

edited

Loading

Coverage Status

coverage: 84.469% (+0.2%) from 84.254% when pulling 8f2d538 on LukasBoll:fixStackOverflowAngularAnyOf into e80a873 on eclipsesource:master.

delete newSchema.oneOf;
delete newSchema.anyOf;
delete newSchema.allOf;
return generateDefaultUISchema(newSchema, 'Group');
Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is the underlying implementation, we typically invoke it via Generate.uischema. Can you adapt accordingly?

@LukasBoll LukasBoll force-pushed the fixStackOverflowAngularAnyOf branch from 08db5e6 to db12562 Compare

July 16, 2023 16:19

@LukasBoll LukasBoll force-pushed the fixStackOverflowAngularAnyOf branch from db12562 to 8f2d538 Compare

July 30, 2023 16:39

@sdirix sdirix merged commit d8d261e into eclipsesource:master

Aug 7, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdirix sdirix sdirix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When using "anyOf" and no UISchema generateDefaultUISchema fails with stack overflow

3 participants

@LukasBoll @coveralls @sdirix