feat: remove state slice when set as undefined by JBBianchi · Pull Request #2163 · eclipsesource/jsonforms
Handles setting a slice state to undefined as removing the said slice.
Related to #1790
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution ❤️
Please add test cases for the new behavior and make sure that the builds are green.
Sorry, I did hammer a bit the CI, I don't have the environment installed locally so I could test before committing.
I hope it's good enough.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution :)
This feature seems to work as expected but this alpha-0 ships the bug reported (and fixed) in #2166 so I'll wait next release to actually use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters